Comments

Nested discussion, sorted card feed, review resolve thread, and mentions with reactions.

Discussion

6
YO
SJ
Sarah JenkinsMaintainer

This is a solid approach for accessible dialogs. Also consider `inert` on the rest of the page while the modal is open — it’s supported in modern browsers now.

AR
Alex Rivera

Great point — we added `inert` in v1.2 alongside the focus trap so screen readers stay inside the dialog.

DC
David Chen

Is `inert` preferable to `aria-hidden` on the root? We’ve been using the latter.

MG
Maria Garcia

The CSS variables comparison was useful. Moving our theme to custom properties cut about 14 KB from the JS bundle.

Comments

4
YO
  • SJ
    Sarah Jenkins

    The density feels right for docs feedback. Sorting by Top is useful during launch week.

  • AR
    Alex Rivera

    Flat threads are easier to scan when reviewing before a release.

  • MG
    Maria Garcia

    Could we pin FAQ answers, or is Top sort enough for that use case?

  • DC
    David Chen

    Looks good. Keep timestamps LTR in RTL layouts.

Review comments

2 open

Line-anchored feedback on this change.

  • SJ
    Sarah JenkinsOpen

    button.tsx:46

    Default height should stay at 46px on mobile — don’t shrink below the control scale.

    AR
    Alex Rivera12m ago

    Agreed — keeping `h-[46px]` and only adjusting padding.

  • DC
    David ChenOpen

    input.tsx:28

    Focus ring looks good — can we match the shared `--ring` token?

Discussion

Mentions
YO
Mention
SJ
Sarah Jenkins

Hey @alex — can you glance at the mention chips before we merge?

Alex Rivera18m ago

On it — will leave notes in the PR.

MG
Maria Garcia

Ship looks solid. @david thoughts on the reaction row density?